ddl: basic support for invisible index #15366

Deardrops · 2020-03-13T11:32:16Z

What problem does this PR solve?

Part of #9246

What is changed and how it works?

Store Invisible Flag in these statements:
- CREATE TABLE t (a INT, INDEX (a) INVISIBLE)
- CREATE INDEX a on t(a) INVISIBLE
- ALTER TABLE t ADD INDEX a INVISIBLE
Add a new column Visible in SHOW INDEX:

mysql> show index from t;
+-------+------------+----------+--------------+-------------+-----------+-------------+----------+--------+------+------------+---------+---------------+---------+------------+
| Table | Non_unique | Key_name | Seq_in_index | Column_name | Collation | Cardinality | Sub_part | Packed | Null | Index_type | Comment | Index_comment | Visible | Expression |
+-------+------------+----------+--------------+-------------+-----------+-------------+----------+--------+------+------------+---------+---------------+---------+------------+
| t     |          1 | a        |            1 | a           | A         |           0 |     NULL | NULL   | YES  | BTREE      |         |               | NO      | NULL       |
+-------+------------+----------+--------------+-------------+-----------+-------------+----------+--------+------+------------+---------+---------------+---------+------------+
1 row in set (0.00 sec)

Add a new column IS_VISIBLE in table information_schema.statistics:

mysql> select table_name, index_name, is_visible from information_schema.statistics where table_name = "t";
+------------+------------+------------+
| table_name | index_name | is_visible |
+------------+------------+------------+
| t          | a          | NO         |
+------------+------------+------------+
1 row in set (0.00 sec)

Show Invisible Index in SHOW CREATE TABLE

mysql> show create table t;
+-------+--------------------------------------------------------------------------------------------------------------------------------------------------+
| Table | Create Table                                                                                                                                     |
+-------+--------------------------------------------------------------------------------------------------------------------------------------------------+
| t     | CREATE TABLE `t` (
  `a` int(11) DEFAULT NULL,
  KEY `a` (`a`) /*!80000 INVISIBLE */
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin |
+-------+--------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

Check List

Tests

Unit test

Code changes

Has exported variable/fields change

Side effects

Increased code complexity

Related changes

None

Release note

None

Deardrops · 2020-03-13T11:43:00Z

/rebuild

codecov · 2020-03-13T12:41:37Z

Codecov Report

❗ No coverage uploaded for pull request base (master@8aad651). Click here to learn what that means.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #15366   +/-   ##
===========================================
  Coverage          ?   80.4052%           
===========================================
  Files             ?        502           
  Lines             ?     133495           
  Branches          ?          0           
===========================================
  Hits              ?     107337           
  Misses            ?      17729           
  Partials          ?       8429

AilinKid

Rest seems ok

AilinKid · 2020-03-13T12:49:22Z

executor/show.go

@@ -852,6 +863,9 @@ func ConstructResultOfShowCreateTable(ctx sessionctx.Context, tableInfo *model.T
 			cols = append(cols, colInfo)
 		}
 		fmt.Fprintf(buf, "(%s)", strings.Join(cols, ","))
+		if idxInfo.Invisible {
+			fmt.Fprintf(buf, ` /*!80000 INVISIBLE */`)


How does comment 80000 come？any reference?

Sorry, I do not find any reference for the /*!80000 INVISIBLE */,
but when test in MySQL 8.0, it does have this behavior.

…sible-index

Deardrops · 2020-03-16T02:31:53Z

/run-all-tests tidb-test=pr/1004

qw4990

LGTM

AilinKid

fix the conflicts

djshow832

LGTM

francis0407

LGTM

sre-bot · 2020-03-17T05:44:26Z

/run-all-tests

sre-bot · 2020-03-17T05:46:31Z

@Deardrops merge failed.

Deardrops · 2020-03-17T07:27:08Z

/run-all-tests

ddl: basic support for invisible index

fd9cd1a

Deardrops added the sig/sql-infra SIG: SQL Infra label Mar 13, 2020

Deardrops requested review from a team as code owners March 13, 2020 11:32

ghost requested review from qw4990, SunRunAway, francis0407, winoros and a team and removed request for a team March 13, 2020 11:32

github-actions bot added the sig/execution SIG execution label Mar 13, 2020

Merge branch 'master' into invisible-index

7d1a25b

AilinKid self-requested a review March 13, 2020 12:46

AilinKid reviewed Mar 13, 2020

View reviewed changes

Deardrops added 3 commits March 16, 2020 09:58

Merge branch 'master' of github.com:pingcap/tidb into invisible-index

de4be83

update parser dependence

e9b6e19

Merge branch 'invisible-index' of github.com:Deardrops/tidb into invi…

c54da3b

…sible-index

Deardrops added the status/PTAL label Mar 16, 2020

SunRunAway removed their request for review March 16, 2020 06:13

qw4990 reviewed Mar 16, 2020

View reviewed changes

Deardrops added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2020

AilinKid reviewed Mar 16, 2020

View reviewed changes

djshow832 reviewed Mar 17, 2020

View reviewed changes

djshow832 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2020

Deardrops added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Mar 17, 2020

Merge remote-tracking branch 'origin/master' into invisible-index

58175b9

francis0407 approved these changes Mar 17, 2020

View reviewed changes

zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2020

Merge branch 'master' into invisible-index

d909dfb

Merge branch 'master' into invisible-index

eeba3ff

bb7133 merged commit 12aabbd into pingcap:master Mar 17, 2020

Deardrops mentioned this pull request Apr 30, 2020

ddl: add alter index visibility DDL support #16914

Merged

Deardrops mentioned this pull request May 9, 2020

sql: introduce invisible index pingcap/docs-cn#3011

Merged

5 tasks

This was referenced Dec 29, 2020

releases: add TiDB 5.0.0-rc release notes pingcap/docs#4507

Closed

releases: add TiDB 5.0 RC release notes pingcap/docs-cn#5189

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ddl: basic support for invisible index #15366

ddl: basic support for invisible index #15366

Deardrops commented Mar 13, 2020 •

edited

Loading

Deardrops commented Mar 13, 2020

codecov bot commented Mar 13, 2020 •

edited

Loading

AilinKid left a comment

AilinKid Mar 13, 2020

Deardrops Mar 16, 2020

AilinKid Mar 16, 2020

Deardrops commented Mar 16, 2020

qw4990 left a comment

AilinKid left a comment

djshow832 left a comment

francis0407 left a comment

sre-bot commented Mar 17, 2020

sre-bot commented Mar 17, 2020

Deardrops commented Mar 17, 2020

ddl: basic support for invisible index #15366

ddl: basic support for invisible index #15366

Conversation

Deardrops commented Mar 13, 2020 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Deardrops commented Mar 13, 2020

codecov bot commented Mar 13, 2020 • edited Loading

Codecov Report

AilinKid left a comment

Choose a reason for hiding this comment

AilinKid Mar 13, 2020

Choose a reason for hiding this comment

Deardrops Mar 16, 2020

Choose a reason for hiding this comment

AilinKid Mar 16, 2020

Choose a reason for hiding this comment

Deardrops commented Mar 16, 2020

qw4990 left a comment

Choose a reason for hiding this comment

AilinKid left a comment

Choose a reason for hiding this comment

djshow832 left a comment

Choose a reason for hiding this comment

francis0407 left a comment

Choose a reason for hiding this comment

sre-bot commented Mar 17, 2020

sre-bot commented Mar 17, 2020

Deardrops commented Mar 17, 2020

Deardrops commented Mar 13, 2020 •

edited

Loading

codecov bot commented Mar 13, 2020 •

edited

Loading