Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ucp: migrate dataForTiKVRegionStatus from package infoschema to executor #15552

Merged
merged 4 commits into from
Mar 30, 2020
Merged

ucp: migrate dataForTiKVRegionStatus from package infoschema to executor #15552

merged 4 commits into from
Mar 30, 2020

Conversation

krzysztofpioro
Copy link
Contributor

UCP #15022

What problem does this PR solve?

fixes #15022

What is changed and how it works?

Migrate dataForTiKVRegionStatus from package infoschema to executor.

Check List

Tests

  • Unit test

@krzysztofpioro krzysztofpioro requested a review from a team as a code owner March 21, 2020 22:55
@sre-bot
Copy link
Contributor

sre-bot commented Mar 21, 2020

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@ghost ghost requested review from SunRunAway and wshwsh12 and removed request for a team March 21, 2020 22:55
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Mar 21, 2020
@CLAassistant
Copy link

CLAassistant commented Mar 21, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Mar 21, 2020
@codecov
Copy link

codecov bot commented Mar 21, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@1637c42). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #15552   +/-   ##
===========================================
  Coverage          ?   80.5067%           
===========================================
  Files             ?        504           
  Lines             ?     135149           
  Branches          ?          0           
===========================================
  Hits              ?     108804           
  Misses            ?      17863           
  Partials          ?       8482

@krzysztofpioro
Copy link
Contributor Author

@crazycs520 PTAL

wshwsh12
wshwsh12 reviewed Mar 29, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 29, 2020
zz-jason
zz-jason approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

Your auto merge job has been accepted, waiting for 15678, 15773

@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

/run-all-tests

@sre-bot sre-bot merged commit 6eda698 into pingcap:master Mar 30, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

Congratulation! You have awarded a badge for usability challenge program! Please fill the form to get your reward! http://tidbcommunity.mikecrm.com/QMCv4QL

@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

Team krzysztofpioro complete task #15022 and get 50 score, currerent score 50

@krzysztofpioro krzysztofpioro deleted the migrateDataForTiKVRegionStatus branch April 19, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@zz-jason zz-jason zz-jason approved these changes

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UCP: Migrate dataForTiKVRegionStatus from package infoschema to executor
5 participants
@krzysztofpioro @sre-bot @CLAassistant @zz-jason @wshwsh12