-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distsql: check the killed flag in the distsql package (#15592) #15617
distsql: check the killed flag in the distsql package (#15592) #15617
Conversation
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@sre-bot merge failed. |
/merge |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Your auto merge job has been accepted, waiting for 15631 |
/run-all-tests |
cherry-pick #15592 to release-4.0
What problem does this PR solve?
Problem Summary:
Fix an issue from the forum https://asktug.com/t/tidb-new-feature-max-execution-time/309
There is no index in this query and TiKV scans the whole table.
max_excution_time doesn't work because the
killed
flag is checked in eachNext
function,the code doesn't run to
Next
until it read sufficient rows in a chunk.What is changed and how it works?
Check the
killed
flag in the distsql package level, so the query could break after reading each region result. The code looks like that:https://github.com/pingcap/tidb/compare/master...tiancaiamao:coprocessor-kill?expand=1#diff-7492d01b7aac81533194642850a45b8eR206
Related changes
#14552
#12852
Check List
Tests
Release note
Improve
max-execution-time
usability by checking the interrupt signal when a new region data is read.