Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: Improve the performance of aggFuncBitXor by using sliding window #16091

Merged
merged 7 commits into from
Apr 15, 2020
Merged

executor: Improve the performance of aggFuncBitXor by using sliding window #16091

merged 7 commits into from
Apr 15, 2020

Conversation

mmyj
Copy link
Member

@mmyj mmyj commented Apr 6, 2020

What problem does this PR solve?

Problem Summary: Improve the performance of the aggFuncBitXor

related #14887

Check List

Tests

  • Unit test

Side effects

  • benchmark
name                                                                                                                                    old time/op  new time/op  delta
rows
WindowFunctionsWithSlidingWindow/(func:bit_xor,_aggColType:int(11),_numFunc:1,_ndv:100,_rows:100000,_sorted:true,_concurrency:1)-16     21.8ms ± 1%   7.2ms ± 1%  -66.95%  (p=0.000 n=10+10)
ranges
WindowFunctionsWithSlidingWindow/(func:bit_xor,_aggColType:int(11),_numFunc:1,_ndv:100,_rows:100000,_sorted:true,_concurrency:1)#01-16   738ms ± 1%     8ms ± 2%  -98.95%  (p=0.000 n=9+10)

new.txt
old.txt

@mmyj mmyj requested a review from a team as a code owner April 6, 2020 14:16
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Apr 6, 2020
@ghost ghost requested review from SunRunAway and removed request for a team April 6, 2020 14:16
@github-actions github-actions bot added the sig/execution SIG execution label Apr 6, 2020
@codecov
Copy link

codecov bot commented Apr 6, 2020 •
edited
Loading

Codecov Report

Merging #16091 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #16091   +/-   ##
===========================================
  Coverage   80.3878%   80.3878%           
===========================================
  Files           506        506           
  Lines        136507     136507           
===========================================
  Hits         109735     109735           
  Misses        18221      18221           
  Partials       8551       8551

@mmyj
Copy link
Member Author

mmyj commented Apr 7, 2020

@SunRunAway PTAL

SunRunAway
SunRunAway reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 7, 2020
qw4990
qw4990 approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 9, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 9, 2020

@mmyj merge failed.

@zz-jason
Copy link
Member

/merge

@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

Your auto merge job has been accepted, waiting for 16076, 16378, 16387

@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

@mmyj merge failed.

@zz-jason zz-jason merged commit 8cd377d into pingcap:master Apr 15, 2020
@SunRunAway SunRunAway mentioned this pull request Sep 7, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmyj @sre-bot @zz-jason @SunRunAway @qw4990