Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: boostrap delete isolation engines from glo... (#16622) #16802

Merged
merged 4 commits into from
Apr 26, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 24, 2020

cherry-pick #16622 to release-3.1


What problem does this PR solve?

issue: close #16624

Problem Summary: When tidb-server is upgraded from 3.1-beta to a higher version. There is a tidb_isolation_read_engines in mysql.global_variables. It may lead a wrong behavior such as tidb-dashboard can't read the cluster-info table. So we add a new version for bootstrap to delete it.

What is changed and how it works?

How it Works: delete the value in mysql.global_variables when tidb-server bootstrap.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 24, 2020

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lzmhhh123 please resolve conflicts.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2020
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 26, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 26, 2020

@sre-bot merge failed.

@zz-jason zz-jason changed the title session: boostrap delete isolation engines from global variables (#16622) session: boostrap delete isolation engines from glo... (#16622) Apr 26, 2020
@zz-jason zz-jason merged commit 8fef6bb into pingcap:release-3.1 Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/session priority/release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants