ddl: fix panic in TestParallelDDL #16969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16969 +/- ##
===========================================
Coverage 80.0143% 80.0143%
===========================================
Files 510 510
Lines 139245 139245
===========================================
Hits 111416 111416
Misses 18837 18837
Partials 8992 8992 |
|
PTAL @SunRunAway @wjhuang2016 |
|
/run-all-tests |
|
Almost one-line PR, PTAL @SunRunAway @wjhuang2016 |
wjhuang2016
reviewed
May 9, 2020
zimulala
reviewed
May 9, 2020
|
/run-all-tests |
bb7133
added
require-LGT3
|
@bb7133 Hi it's LGT3 in fact |
zimulala
added
status/LGT3
|
/run-all-tests |
|
@lance6716 |
|
@lance6716 merge failed. |
|
/run-integration-copr-test |
|
/rebuild |
|
/rebuild |
1 similar comment
|
/rebuild |
|
/merge |
lance6716
added a commit
to lance6716/tidb
that referenced
this pull request
Jul 4, 2020
zz-jason
pushed a commit
that referenced
this pull request
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15597
Problem Summary:
MockContextfailed interface type assertion, causing a panic. Proof see ddl_worker_test.go:testDDLSuite.TestParallelDDL failed #15597 (comment)try to reduce alloc slightly, BTW
What is changed and how it works?
check type assertion and return
statistics.PseudoRowCounton failurechange 'make new slice, append old elements, append new element' to 'append new element to old slice'
Related changes
Check List
Tests
Side effects
Release note