-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix pre-split region timeout constraint not work when create table #17459
Conversation
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #17459 +/- ##
===========================================
Coverage 79.4954% 79.4954%
===========================================
Files 520 520
Lines 140120 140120
===========================================
Hits 111389 111389
Misses 19757 19757
Partials 8974 8974 |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Need to cherry-pick? |
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: sre-bot <[email protected]>
cherry pick to release-3.0 in PR #17617 |
Signed-off-by: sre-bot <[email protected]>
cherry pick to release-3.1 in PR #17618 |
Signed-off-by: sre-bot <[email protected]>
cherry pick to release-4.0 in PR #17619 |
…le (#17459) (#17618) * cherry pick #17459 to release-3.1 Signed-off-by: sre-bot <[email protected]> * fix conflict Signed-off-by: crazycs520 <[email protected]> Co-authored-by: crazycs <[email protected]>
What problem does this PR solve?
close #17458
As the title said.
What is changed and how it works?
Use
context.WithTimeout
.Related changes
Check List
Tests
Side effects
Release note