Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix pre-split region timeout constraint not work when create table #17459

Merged
merged 11 commits into from
Jun 3, 2020

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

close #17458

As the title said.

What is changed and how it works?

Use context.WithTimeout.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Manual test

Side effects

  • No

Release note

  • Fix pre-split region timeout constraint not work when create table.

Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
@crazycs520 crazycs520 added type/bugfix This PR fixes a bug. sig/sql-infra SIG: SQL Infra labels May 27, 2020
@crazycs520 crazycs520 requested a review from a team as a code owner May 27, 2020 12:49
@ghost ghost requested review from qw4990 and removed request for a team May 27, 2020 12:49
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #17459 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #17459   +/-   ##
===========================================
  Coverage   79.4954%   79.4954%           
===========================================
  Files           520        520           
  Lines        140120     140120           
===========================================
  Hits         111389     111389           
  Misses        19757      19757           
  Partials       8974       8974           

@github-actions github-actions bot added the sig/execution SIG execution label May 27, 2020
@crazycs520
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjhuang2016
Copy link
Member

Need to cherry-pick?

ddl/split_region.go Show resolved Hide resolved
ddl/split_region.go Outdated Show resolved Hide resolved
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 merged commit 6bb9b30 into pingcap:master Jun 3, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Jun 3, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

cherry pick to release-3.0 in PR #17617

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Jun 3, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

cherry pick to release-3.1 in PR #17618

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Jun 3, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

cherry pick to release-4.0 in PR #17619

zimulala pushed a commit that referenced this pull request Jun 5, 2020
sre-bot added a commit that referenced this pull request Jun 10, 2020
…le (#17459) (#17618)

* cherry pick #17459 to release-3.1

Signed-off-by: sre-bot <[email protected]>

* fix conflict

Signed-off-by: crazycs520 <[email protected]>

Co-authored-by: crazycs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidb_wait_split_region_timeout don't work in pre-split region when create table
4 participants