types: fix StrToDate handling of %h and %p (#17395) #17498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
component/expression
contribution
ghost
requested review from
zz-jason
added
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17395 to release-4.0
What problem does this PR solve?
Problem Summary: handling of
%hin date format is not consistent with MySQL. MySQL only allows1..12(with or without zero padding), while TiDB allows01..24(with zero padding).What is changed and how it works?
What's Changed:
types/time.go:hour24TwoDigits, now%hand%Iare synonyms.How it Works:
Related changes
N/A
Check List
Tests
Side effects
13:00:00 am,%h:%i:%s %pused to be valid, now it is not, since%hmust be in1..12range.1:00:00 am,%h:%i:%s %pused to be invalid (single digit hour), not it is.Release note
%hin date formats should now be in 1..12 range.