Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: isolation read do not filter system tables (#17556) #17719

Merged
merged 2 commits into from
Jun 6, 2020
Merged

planner: isolation read do not filter system tables (#17556) #17719

merged 2 commits into from
Jun 6, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 5, 2020

cherry-pick #17556 to release-4.0

What problem does this PR solve?

Issue Number: close #17551

Problem Summary: make isolation read completely ignore system tables.

What is changed and how it works?

What's Changed: if the type of access path is TiDB. Isolation read ignore it.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • make isolation read do not filter system tables.

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 5, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Jun 5, 2020
Merged
@sre-bot sre-bot added compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. sig/planner SIG: Planner type/4.0-cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Jun 5, 2020
@sre-bot sre-bot added this to the v4.0.1 milestone Jun 5, 2020
XuHuaiyu
XuHuaiyu reviewed Jun 5, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 5, 2020
@lzmhhh123
Copy link
Contributor

@lawyerphx PTAL

@lzmhhh123
Copy link
Contributor

/run-integration-ddl-test

danmay319
danmay319 approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@danmay319 danmay319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danmay319 danmay319 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 5, 2020
@bb7133 bb7133 modified the milestones: v4.0.1, v4.0.2 Jun 6, 2020
@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Jun 6, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 6, 2020

Your auto merge job has been accepted, waiting for:

  • 17694
  • 17680
  • 17681
  • 17648
  • 17705

@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 6, 2020

/run-all-tests

@sre-bot sre-bot merged commit 203ec5a into pingcap:release-4.0 Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@danmay319 danmay319 danmay319 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees

@lzmhhh123 lzmhhh123

Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.2
Development

Successfully merging this pull request may close these issues.
6 participants
@sre-bot @lzmhhh123 @XuHuaiyu @danmay319 @bb7133 @zz-jason