Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: support partitioned table for table scatter (#17624) #17864

Merged
merged 5 commits into from
Jul 28, 2020

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Jun 9, 2020

What problem does this PR solve?

support partitioned table for table scatter
Issue Number: close #17623
pick: #17624

What is changed and how it works?

How it Works:

  • use psychic table id.

Release note

  • Fix the partition table issue in table scatter API.

* server: support partitioned tabel for table scatter

Signed-off-by: nolouch <[email protected]>

* fix scheduler name

Signed-off-by: nolouch <[email protected]>

* fix ci

Signed-off-by: nolouch <[email protected]>

* fix ci

Signed-off-by: nolouch <[email protected]>

Co-authored-by: crazycs <[email protected]>
Co-authored-by: pingcap-github-bot <[email protected]>
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #17864 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #17864   +/-   ##
===========================================
  Coverage   79.2416%   79.2416%           
===========================================
  Files           543        543           
  Lines        146534     146534           
===========================================
  Hits         116116     116116           
  Misses        21066      21066           
  Partials       9352       9352           

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added type/enhancement The issue or PR belongs to an enhancement. status/LGT1 Indicates that a PR has LGTM 1. labels Jun 9, 2020
docs/tidb_http_api.md Outdated Show resolved Hide resolved
docs/tidb_http_api.md Outdated Show resolved Hide resolved
@nolouch
Copy link
Member Author

nolouch commented Jun 30, 2020

PTAL @zimulala

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2020
@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@nolouch merge failed.

@jackysp
Copy link
Member

jackysp commented Jul 28, 2020

/run-check_dev_2

@jackysp jackysp merged commit 901d531 into pingcap:master Jul 28, 2020
@nolouch nolouch deleted the pick-scatter branch July 28, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support partitioned table for table scatter API
4 participants