Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: distinguish transactions by mode #17912

Merged
merged 6 commits into from
Jun 15, 2020
Merged

metrics: distinguish transactions by mode #17912

merged 6 commits into from
Jun 15, 2020

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Jun 10, 2020

Signed-off-by: Shuaipeng Yu [email protected]

What problem does this PR solve?

Issue Number: close #17377

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:
Use "pessimistic" and "optimistic" to distinguish transactions.

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • start a new cluster with this branch
  • check out the metrics

Release note

  • No release note

@jackysp
Copy link
Member Author

jackysp commented Jun 10, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2020

Visit the grafana server at: http://172.16.5.5:32141, it will last for 5 hours

@github-actions github-actions bot added the sig/execution SIG execution label Jun 10, 2020
@jackysp
update
19af4f3 
Signed-off-by: Shuaipeng Yu <[email protected]>
@jackysp
Copy link
Member Author

jackysp commented Jun 10, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2020

Visit the grafana server at: http://172.16.5.5:30826, it will last for 5 hours

@jackysp
fix
0b40e0b 
Signed-off-by: Shuaipeng Yu <[email protected]>
@jackysp
Copy link
Member Author

jackysp commented Jun 10, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2020

Visit the grafana server at: http://172.16.5.5:32268, it will last for 5 hours

@jackysp
update
225bdf3 
Signed-off-by: Shuaipeng Yu <[email protected]>
@jackysp jackysp requested review from lysu and coocood June 10, 2020 09:24
@jackysp
Copy link
Member Author

jackysp commented Jun 10, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Jun 10, 2020

Visit the grafana server at: http://172.16.5.5:32083, it will last for 5 hours

wjhuang2016
wjhuang2016 reviewed Jun 11, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu
Copy link
Contributor

lysu commented Jun 11, 2020

maybe we still need LblInternal to explain some problem for our customer(e.g. why I do nothing but it running stmt?)

@jackysp
Copy link
Member Author

jackysp commented Jun 11, 2020

maybe we still need LblInternal to explain some problem for our customer(e.g. why I do nothing but it running stmt?)

We have already added the internal label in SQL level, I think it provides enough info for the user.

lysu
lysu approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member Author

jackysp commented Jun 11, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

Sorry @jackysp, you don't have permission to trigger auto merge event on this branch. You are not a committer for the related sigs:execution(slack).

@jackysp jackysp removed the sig/execution SIG execution label Jun 11, 2020
@jackysp
Copy link
Member Author

jackysp commented Jun 11, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Jun 11, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

/run-all-tests

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #17912 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #17912   +/-   ##
===========================================
  Coverage   79.5908%   79.5908%           
===========================================
  Files           524        524           
  Lines        142750     142750           
===========================================
  Hits         113616     113616           
  Misses        20002      20002           
  Partials       9132       9132

@sre-bot
Copy link
Contributor

sre-bot commented Jun 11, 2020

@jackysp merge failed.

@jackysp jackysp removed the sig/execution SIG execution label Jun 15, 2020
@jackysp
Copy link
Member Author

jackysp commented Jun 15, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@github-actions github-actions bot added the sig/execution SIG execution label Jun 15, 2020
@jackysp jackysp removed the sig/execution SIG execution label Jun 15, 2020
@jackysp jackysp merged commit b8fb4b0 into pingcap:master Jun 15, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 15, 2020
@jackysp @ti-srebot
cherry pick pingcap#17912 to release-4.0
e55a79f 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jun 15, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #18027

ti-srebot added a commit that referenced this pull request Jul 28, 2020
@ti-srebot
metrics: distinguish transactions by mode (#17912) (#18027)
f29d4ce 
Signed-off-by: ti-srebot <[email protected]>
@jackysp jackysp deleted the seperate_by_txn_type branch November 25, 2020 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@lysu lysu lysu approved these changes

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a transaction mode label for certain transaction metrics
5 participants
@jackysp @sre-bot @lysu @ti-srebot @wjhuang2016