Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix sequence cache negative problem (#18071) #18103

Merged
merged 2 commits into from
Jun 18, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #18071 to release-4.0


Signed-off-by: AilinKid [email protected]

What problem does this PR solve?

Issue Number: close #17945

What is changed and how it works?

What's Changed:
check cache shouldn't be negative when create sequence

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • PR to update pingcap/tidb-ansible:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • ddl: fix sequence cache negative problem

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@AilinKid please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tidb/invitations

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 18, 2020
@AilinKid
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 18, 2020
@AilinKid
Copy link
Contributor

/run-all-tests

@AilinKid
Copy link
Contributor

/run-unit-test

@zimulala zimulala merged commit 6dc7e03 into pingcap:release-4.0 Jun 18, 2020
@AilinKid AilinKid deleted the release-4.0-096f2e80cb74 branch June 18, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants