executor: add new agg function APPROX_COUNT_DISTINCT (#17175)
#18120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
|
/run-all-tests |
ti-srebot
added
sig/execution
|
@solotzg please accept the invitation then you can push to the cherry-pick pull requests. |
Signed-off-by: Tong Zhigao <[email protected]>
Signed-off-by: Tong Zhigao <[email protected]>
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
XuHuaiyu
added
status/LGT2
|
/merge |
|
Sorry @XuHuaiyu, you don't have permission to trigger auto merge event on this branch. |
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17175 to release-4.0
Signed-off-by: Tong Zhigao [email protected]
What problem does this PR solve?
Issue Number: close #14632
Problem Summary:
What is changed and how it works?
Add new agg function
APPROX_COUNT_DISTINCT.Use
BJKSTalgorithm to compute approximate result of distinct count.For the calculation state, it uses a sample of element hash values with a size up to 2^16. Compared with the widely known HyperLogLog algorithm, this algorithm is less effective in terms of accuracy and memory consumption (even up to proportionality), but it is adaptive. This means that with fairly high accuracy, it consumes less memory during simultaneous computation of cardinality for a large number of data sets whose cardinality has power law distribution (i.e. in cases when most of the data sets are small). This algorithm is also very accurate for data sets with small cardinality and very efficient on CPU.
For TiFlash, TiDB can push down cop request and merge all partial result. For other engine, TiDB needs to collect all original data and compute all by itself.
Tests
Release note
APPROX_COUNT_DISTINCTto support approximate count distinct.