store/tikv: limit batch split count for one request #18191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor1996 <[email protected]>
|
/release |
|
/release |
Codecov Report
@@ Coverage Diff @@
## master #18191 +/- ##
================================================
+ Coverage 79.5137% 80.3879% +0.8742%
================================================
Files 535 535
Lines 144111 149546 +5435
================================================
+ Hits 114588 120217 +5629
+ Misses 20274 20094 -180
+ Partials 9249 9235 -14 |
crazycs520
added
needs-cherry-pick-3.0
type/enhancement
|
/release |
|
/build |
zimulala
added
the
status/can-merge
|
/run-all-tests |
|
/run-all-tests |
|
/merge |
|
@zz-jason Oops! This PR requires at least 2 LGTMs to merge. The current number of |
|
/merge |
|
@zz-jason Oops! This PR requires at least 2 LGTMs to merge. The current number of |
|
/approve |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 21, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.0 in PR #18694 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 21, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.1 in PR #18695 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 21, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #18696 |
ti-srebot
added a commit
that referenced
this pull request
Jul 24, 2020
Signed-off-by: ti-srebot <[email protected]>
zz-jason
pushed a commit
that referenced
this pull request
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Connor1996 [email protected]
What problem does this PR solve?
Too much split may cause TiKV latency spike.
What is changed and how it works?
For one batch split request, TiKV will write all newly created regions' metadata into one write batch of RocksDB. So limit the batch split for one request and separate it into multiple requests.
Related changes
Check List
Release note