Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[store/tikv] add some unit tests for batch coprocessor #18514

Merged
merged 10 commits into from
Jul 15, 2020

Conversation

hanfei1991
Copy link
Member

What problem does this PR solve?

Problem Summary:
Add some unit tests for batch coprocessor.

What is changed and how it works?

What's Changed:
mocktikv supports batch coprocessor request and add some tests for

  • store error once
  • store error forever
  • context cancel once
  • two tiflash peer and one of them is down

Check List

Tests

  • Unit test

Release note

add unit tests for batch coprocessor

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #18514 into master will increase coverage by 0.2870%.
The diff coverage is 81.8035%.

@@               Coverage Diff                @@
##             master     #18514        +/-   ##
================================================
+ Coverage   79.2829%   79.5699%   +0.2870%     
================================================
  Files           541        540         -1     
  Lines        145378     145947       +569     
================================================
+ Hits         115260     116130       +870     
+ Misses        20822      20488       -334     
- Partials       9296       9329        +33     

@hanfei1991 hanfei1991 requested a review from lysu July 13, 2020 14:23
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 14, 2020
@lysu lysu requested a review from lzmhhh123 July 14, 2020 10:41
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 15, 2020
@lzmhhh123
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 18445

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@hanfei1991 merge failed.

@hanfei1991
Copy link
Member Author

/run-all-tests

1 similar comment
@hanfei1991
Copy link
Member Author

/run-all-tests

@hanfei1991
Copy link
Member Author

/run-all-tests

@lzmhhh123 lzmhhh123 merged commit 971cf97 into pingcap:master Jul 15, 2020
@hanfei1991 hanfei1991 deleted the hanfei/test-batch-cop branch July 15, 2020 07:58
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 15, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #18583

ti-srebot added a commit that referenced this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants