Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: fix BatchPointGet wrong result. (#18814) #18815

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #18814 to release-4.0


What problem does this PR solve?

in-transaction BatchPointGet returns wrong result in certain case.

What is changed and how it works?

Do not modify input keys slice when do snapshot batch get.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Release note

  • fix BatchPointGet wrong result.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 28, 2020
@coocood
Copy link
Member

coocood commented Jul 28, 2020

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2020
@coocood
Copy link
Member

coocood commented Jul 28, 2020

/run-check_dev

@coocood
Copy link
Member

coocood commented Jul 28, 2020

/run-check_dev

1 similar comment
@jackysp
Copy link
Member

jackysp commented Jul 28, 2020

/run-check_dev

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 28, 2020
@jackysp jackysp merged commit 575bc85 into pingcap:release-4.0 Jul 28, 2020
imtbkcat pushed a commit that referenced this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants