ddl: change drop partition and truncate partition's job args to support multi partition id array (#18419) #18930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
|
/run-all-tests |
ti-srebot
added
compatibility-breaker
|
/run-all-tests |
ti-srebot
added
status/LGT2
|
/run-check_dev |
|
LGTM |
|
@lance6716,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: ddl(slack). |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
bb7133
approved these changes
Aug 3, 2020
ti-srebot
added
status/LGT3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18419 to release-4.0
Signed-off-by: AilinKid [email protected]
What problem does this PR solve?
it is prepared for cancel
add multi partition actionwhich is in mid stateProblem Summary: change drop partition and truncate partition's job args to support multi partition id array
What is changed and how it works?
What's Changed:
1: change drop partition and truncate partition's job args to multi id array
2: support ddl worker to handle these two action and add ids to delete range table.
Check List
Tests
Side effects
Release note
1: rolling upgrade the cluster during the drop partition DDL operation
2: degrade to old tidb if the model data has been written and the DDL operation is not finished