Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add proposal for global index #18982

Merged
merged 3 commits into from
Aug 17, 2020

Conversation

ldeng-ustc
Copy link
Contributor

@ldeng-ustc ldeng-ustc commented Aug 4, 2020

What problem does this PR solve?

This PR adds proposal for global index support.

What is changed and how it works?

None.

Release note

  • No release note.

@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Aug 4, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Aug 4, 2020

@ldeng-ustc
Copy link
Contributor Author

PTAL @tiancaiamao

docs/design/2020-08-04-global-index.md Outdated Show resolved Hide resolved
docs/design/2020-08-04-global-index.md Outdated Show resolved Hide resolved
docs/design/2020-08-04-global-index.md Outdated Show resolved Hide resolved
docs/design/2020-08-04-global-index.md Outdated Show resolved Hide resolved
docs/design/2020-08-04-global-index.md Outdated Show resolved Hide resolved
docs/design/2020-08-04-global-index.md Outdated Show resolved Hide resolved

#### Drop Table

Add extra one range deletion to clean global indexes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just dropping the key range started with tableID prefix should work.

docs/design/2020-08-04-global-index.md Outdated Show resolved Hide resolved
docs/design/2020-08-04-global-index.md Outdated Show resolved Hide resolved

## Implementation

DDL operations will be implemented first. Plan and executor supports will be implemented after [new PartitionTable executor](https://github.com/pingcap/tidb/issues/18016) is completed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's almost done already, you can just try the latest master code.

@tiancaiamao
Copy link
Contributor

I just comment on some spells. The content looks good to me.
Though I have to point out, it still missing a lot of details, and much auxiliary functionality is not considered like: admin check table, HTTP API, pre-split region, and so on...

PTAL @coocood @wjhuang2016 @imtbkcat @lysu

@sre-bot
Copy link
Contributor

sre-bot commented Aug 7, 2020

@tiancaiamao
Copy link
Contributor

PTAL @coocood @wjhuang2016 @imtbkcat @lysu

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 17, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Aug 17, 2020

@lysu
Copy link
Contributor

lysu commented Aug 17, 2020

LGTM

@coocood @wjhuang2016 do you need more take look?

@coocood
Copy link
Member

coocood commented Aug 17, 2020

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 17, 2020
@lysu
Copy link
Contributor

lysu commented Aug 17, 2020

/run-check_release_note

@lysu
Copy link
Contributor

lysu commented Aug 17, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 17, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 19202

@ti-srebot
Copy link
Contributor

/run-all-tests

@lysu
Copy link
Contributor

lysu commented Aug 17, 2020

/rebuild

@ti-srebot
Copy link
Contributor

@ldeng-ustc merge failed.


#### Drop Partition

In global index, all index entries in a partition is not continuous. It is impossible to delete all index entries of a partition in a single range deletion. So, we add a reorg state (just like add index), which scan records in the partition and remove relative index entries.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the redundant blank space in single range

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants