-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: dump time length as 0 directly for zero value in date/datetime/timestamp type for prepare stmt (#18825) #19093
Merged
zimulala
merged 2 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-25bd46b68fcb
Aug 18, 2020
Merged
server: dump time length as 0 directly for zero value in date/datetime/timestamp type for prepare stmt (#18825) #19093
zimulala
merged 2 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-25bd46b68fcb
Aug 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
ti-srebot
requested review from
bb7133,
coocood,
crazycs520,
lysu and
zimulala
August 10, 2020 06:27
/run-integration-ddl-test |
/run-build_check_race |
zimulala
reviewed
Aug 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Aug 17, 2020
zimulala
approved these changes
Aug 18, 2020
/merge |
Sorry @zimulala, you don't have permission to trigger auto merge event on this branch. |
/run-all-tests |
/run-unit-test |
1 similar comment
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18825 to release-4.0
Signed-off-by: AilinKid [email protected]
What problem does this PR solve?
Issue Number: close #18824
Problem Summary: fix the issue coming from https://asktug.com/t/topic/36154/12
What is changed and how it works?
dump 0 (date/datetime/timestamp) time's length as 0 directly
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Release note