Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: dump time length as 0 directly for zero value in date/datetime/timestamp type for prepare stmt (#18825) #19093

Merged
merged 2 commits into from
Aug 18, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #18825 to release-4.0


Signed-off-by: AilinKid [email protected]

What problem does this PR solve?

Issue Number: close #18824

Problem Summary: fix the issue coming from https://asktug.com/t/topic/36154/12

What is changed and how it works?

dump 0 (date/datetime/timestamp) time's length as 0 directly

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • server: fix dump time length as 0 directly for zero value in date/datetime/timestamp type

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@AilinKid
Copy link
Contributor

/run-integration-ddl-test

@AilinKid
Copy link
Contributor

/run-build_check_race

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2020
@lysu
Copy link
Contributor

lysu commented Aug 17, 2020

/approve

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 17, 2020
@zimulala
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @zimulala, you don't have permission to trigger auto merge event on this branch.
The version releasement is in progress.

@zimulala
Copy link
Contributor

/run-all-tests

@AilinKid
Copy link
Contributor

/run-unit-test

1 similar comment
@AilinKid
Copy link
Contributor

/run-unit-test

@zimulala zimulala merged commit e10bd72 into pingcap:release-4.0 Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants