Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: fix a encode bug causes the wrong result of hashJoin with set and enum #19175

Merged
merged 5 commits into from
Aug 20, 2020

Conversation

wjhuang2016
Copy link
Member

Signed-off-by: wjhuang2016 [email protected]

What problem does this PR solve?

Refer to #18855

What is changed and how it works?

Related changes

Check List

Tests

  • Unit test

Side effects

Release note

  • fix a encode bug causes the wrong result of hashJoin with set and enum

Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016 wjhuang2016 added the type/bugfix This PR fixes a bug. label Aug 13, 2020
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 14, 2020
qw4990
qw4990 previously approved these changes Aug 14, 2020
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 14, 2020
ti-srebot
ti-srebot previously approved these changes Aug 14, 2020
@wshwsh12 wshwsh12 added this to the v3.0.18 milestone Aug 20, 2020
@wjhuang2016
Copy link
Member Author

/run-all-tests

Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016 wjhuang2016 dismissed stale reviews from ti-srebot and qw4990 via fdc97c6 August 20, 2020 03:17
Signed-off-by: wjhuang2016 <[email protected]>
@jebter
Copy link

jebter commented Aug 20, 2020

/run-unit-test

@qw4990
Copy link
Contributor

qw4990 commented Aug 20, 2020

/merge

@ti-srebot
Copy link
Contributor

Sorry @qw4990, you don't have permission to trigger auto merge event on this branch.
The version releasement is in progress.

@jebter
Copy link

jebter commented Aug 20, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 20, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit dac780e into pingcap:release-3.0 Aug 20, 2020
@wjhuang2016 wjhuang2016 deleted the v3.0-fix-hash-enum branch November 17, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants