-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix bug of tiflash executing apply #19182
Merged
lzmhhh123
merged 3 commits into
pingcap:master
from
hanfei1991:hanfei/fix-tiflash-apply
Aug 14, 2020
Merged
executor: fix bug of tiflash executing apply #19182
lzmhhh123
merged 3 commits into
pingcap:master
from
hanfei1991:hanfei/fix-tiflash-apply
Aug 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanfei1991
requested review from
wshwsh12 and
lzmhhh123
and removed request for
a team
August 13, 2020 10:27
hanfei1991
changed the title
[executor] fix bug of tiflash executing apply
executor: fix bug of tiflash executing apply
Aug 14, 2020
lzmhhh123
reviewed
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wshwsh12
reviewed
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ti-srebot
approved these changes
Aug 14, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Aug 14, 2020
/run-all-tests |
@hanfei1991 merge failed. |
/run-all-tests |
/merge |
/run-all-tests |
@hanfei1991 merge failed. |
hanfei1991
added a commit
to hanfei1991/tidb
that referenced
this pull request
Aug 14, 2020
Co-authored-by: ti-srebot <[email protected]>
hanfei1991
added a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 14, 2020
executor: fix bug of tiflash executing apply (pingcap#19182)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close pingcap/tiflash#999
Problem Summary:
correlated column is failed in tiflash mode.
What is changed and how it works?
What's Changed:
rebuild pd correctly when building table scan.
How it Works:
Related changes
Tests
Release note