-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: use int instead of fmt.Stringer as executor id #19207
Conversation
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Signed-off-by: crazycs520 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #19207 +/- ##
===========================================
Coverage 79.4944% 79.4944%
===========================================
Files 549 549
Lines 152432 152432
===========================================
Hits 121175 121175
Misses 21724 21724
Partials 9533 9533 |
/bench |
Benchmark Report
@@ Benchmark Diff @@
================================================================================
--- tidb: a4d26bd57c8cd3bf7605912cec89fc1a538ebc88
+++ tidb: e14b57c6bc1521827db7fb55014542cebf81226f
tikv: ae7a6ecee6e3367da016df0293a9ffe9cc2b5705
pd: ec99270dfe418971fd8c62b87d23296fffa12265
================================================================================
oltp_update_index:
* QPS: 16632.75 ± 0.43% (std=54.09) delta: -0.21% (p=0.458)
* Latency p50: 7.69 ± 0.45% (std=0.03) delta: 0.24%
* Latency p99: 15.55 ± 0.00% (std=0.00) delta: 0.91%
oltp_insert:
* QPS: 20777.02 ± 0.18% (std=27.78) delta: 1.57% (p=0.017)
* Latency p50: 6.16 ± 0.16% (std=0.01) delta: -1.48%
* Latency p99: 12.52 ± 0.00% (std=0.00) delta: -1.80%
oltp_update_non_index:
* QPS: 20978.87 ± 0.41% (std=61.64) delta: -0.15% (p=0.446)
* Latency p50: 6.10 ± 0.45% (std=0.02) delta: 0.12%
* Latency p99: 12.75 ± 0.00% (std=0.00) delta: 0.00%
oltp_read_write:
* QPS: 30995.52 ± 0.22% (std=46.45) delta: 0.05% (p=0.678)
* Latency p50: 83.53 ± 0.23% (std=0.14) delta: -0.04%
* Latency p99: 148.95 ± 0.90% (std=1.34) delta: 0.91%
oltp_point_select:
* QPS: 66020.60 ± 0.85% (std=377.42) delta: -0.95% (p=0.069)
* Latency p50: 1.94 ± 0.34% (std=0.00) delta: 1.22%
* Latency p99: 8.90 ± 0.00% (std=0.00) delta: 3.73%
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-unit-test |
/run-all-tests |
/run-integration-copr-test |
/run-integration-common-test |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-4.0 in PR #19279 |
Signed-off-by: ti-srebot <[email protected]> Signed-off-by: crazycs520 <[email protected]>
What problem does this PR solve?
fix #18899
int
(plan id) instead offmt.Stringer
as executorid
SearchTrackerWithoutLock
forTracker
to avoid needless lock:benchmark
For big-quey like union with 10000 select statement:
benchmark the
core.EncodePlan
function, this pr almost 25 times faster than before.Related changes
Check List
Tests
Side effects
Release note