-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix insert check after lock #19236
Merged
Merged
fix insert check after lock #19236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfzjywxk
added
type/bugfix
This PR fixes a bug.
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
sig/transaction
SIG:Transaction
type/3.0-cherry-pick
component/executor
sig/executor
labels
Aug 17, 2020
cfzjywxk
requested review from
lysu,
coocood,
tiancaiamao,
jackysp,
bobotu and
crazycs520
August 17, 2020 08:22
LGTM |
bobotu
reviewed
Aug 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
approved these changes
Aug 19, 2020
LGTM |
ti-srebot
added
status/LGT3
The PR has already had 3 LGTM.
and removed
status/LGT2
Indicates that a PR has LGTM 2.
labels
Aug 19, 2020
tiancaiamao
approved these changes
Aug 19, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Aug 19, 2020
/run-all-tests |
/run-integration-ddl-test |
@cfzjywxk merge failed. |
/merge |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/executor
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
sig/transaction
SIG:Transaction
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT3
The PR has already had 3 LGTM.
type/bugfix
This PR fixes a bug.
type/3.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cherry-pick #19004 to release 3.0 to close #18958
What is changed and how it works?
What's Changed:
In the release 3.0 branch, the pessimistic lock will not return values for point get executor, a new flag "snapValExist" is used to mark the value using snapshot read does exist or not.
For point get executor,
How it Works:
Related changes
Check List
Tests
Side effects
Release note