Fix error result union scan with apply (#19245) #19297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
|
/run-all-tests |
|
@ichn-hu please accept the invitation then you can push to the cherry-pick pull requests. |
|
LGTM |
ti-srebot
added
status/LGT2
SunRunAway
approved these changes
Aug 20, 2020
ti-srebot
added
status/LGT3
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
/run-unit-test |
|
@ti-srebot merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #19245 to release-3.0
What problem does this PR solve?
Issue Number: partially solved #19136 for version before 4.0
Problem Summary:
Apply executor would read UnionScan multiple times, so we need to reset some variables in the executor.
What is changed and how it works?
What's Changed:
Implement Close for UnionScan.
Related changes
Check List
Tests
Side effects
No side effects.
Release note