Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: update stats per table in the pipeline #19370

Merged
merged 9 commits into from
Sep 15, 2020
Merged

statistics: update stats per table in the pipeline #19370

merged 9 commits into from
Sep 15, 2020

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Aug 21, 2020 •
edited
Loading

What problem does this PR solve?

Issue Number: close #19358

Problem Summary: updates per table instead of all to reduce data size

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test (no idea)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • update stats per table to avoid OOM

@fzhedu fzhedu requested a review from a team as a code owner August 21, 2020 13:06
@fzhedu fzhedu requested review from eurekaka and removed request for a team August 21, 2020 13:06
@fzhedu fzhedu requested a review from winoros August 24, 2020 10:08
winoros
winoros reviewed Sep 1, 2020
View reviewed changes
statistics/handle/update.go Outdated Show resolved Hide resolved
@fzhedu
Copy link
Contributor Author

fzhedu commented Sep 3, 2020

/run-check_dev_2

@fzhedu fzhedu requested a review from winoros September 3, 2020 02:34
fzhedu
fzhedu commented Sep 3, 2020
View reviewed changes
statistics/handle/update.go Outdated Show resolved Hide resolved
@fzhedu fzhedu changed the title stats: Update Stats per table stats: Update Stats per table in pipeline Sep 3, 2020
@fzhedu
Copy link
Contributor Author

fzhedu commented Sep 4, 2020

/run-check_dev_2

@zz-jason zz-jason changed the title stats: Update Stats per table in pipeline statistics: update stats per table in the pipeline Sep 5, 2020
@fzhedu
Copy link
Contributor Author

fzhedu commented Sep 8, 2020

/run-check_dev_2

@fzhedu
Copy link
Contributor Author

fzhedu commented Sep 8, 2020

/run-unit-test

@fzhedu fzhedu requested a review from XuHuaiyu September 8, 2020 04:26
@fzhedu
Copy link
Contributor Author

fzhedu commented Sep 8, 2020

/run-unit-test

@fzhedu
Copy link
Contributor Author

fzhedu commented Sep 8, 2020

/run-check_dev_2

@fzhedu fzhedu requested a review from winoros September 14, 2020 08:46
winoros
winoros reviewed Sep 14, 2020
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2020
SunRunAway
SunRunAway approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 15, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 411eba6 into pingcap:master Sep 15, 2020
@fzhedu
Copy link
Contributor Author

fzhedu commented Sep 15, 2020

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 15, 2020
@fzhedu @ti-srebot
cherry pick pingcap#19370 to release-4.0
5a3f0e2 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 15, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20013

SunRunAway pushed a commit that referenced this pull request Sep 16, 2020
@ti-srebot
cherry pick #19370 to release-4.0 (#20013)
82d5113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/statistics sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schema: fetch all results of internal sql would cause OOM
4 participants
@fzhedu @SunRunAway @ti-srebot @winoros