Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

range: build right range for NULL value on index column (#19385) #19430

Merged
merged 1 commit into from
Aug 25, 2020
Merged

range: build right range for NULL value on index column (#19385) #19430

merged 1 commit into from
Aug 25, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19385 to release-4.0

What problem does this PR solve?

Issue Number: close #19100

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

  1. Use keepNull to build range
    How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

  • Build right range for NULL value on index column

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Aug 25, 2020
Merged
@ti-srebot ti-srebot added component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/planner SIG: Planner type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels Aug 25, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Aug 25, 2020
@wshwsh12 wshwsh12 modified the milestones: v4.0.6, v4.0.5 Aug 25, 2020
@wshwsh12
Copy link
Contributor

/run-unit-test
/run-integration-ddl-test

@XuHuaiyu
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 25, 2020
SunRunAway
SunRunAway approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 25, 2020
@jebter
Copy link

jebter commented Aug 25, 2020

/run-integration-ddl-test

@jebter
Copy link

jebter commented Aug 25, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 25, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@jebter
Copy link

jebter commented Aug 25, 2020

/run-integration-ddl-test

@ti-srebot ti-srebot merged commit 7d6fd41 into pingcap:release-4.0 Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@winoros winoros Awaiting requested review from winoros

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@wshwsh12 wshwsh12

Labels
component/expression priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @wshwsh12 @XuHuaiyu @jebter @SunRunAway