Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry: support collecting RAID information to ... (#19171) #19457

Merged
merged 2 commits into from
Sep 2, 2020
Merged

telemetry: support collecting RAID information to ... (#19171) #19457

merged 2 commits into from
Sep 2, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19171 to release-4.0

What is changed and how it works?

[root@tikv-0001 tidb]# lsblk
NAME    MAJ:MIN RM   SIZE RO TYPE  MOUNTPOINT
vda     253:0    0    40G  0 disk  
└─vda1  253:1    0    40G  0 part  /
vdb     253:16   0 744.5G  0 disk  
└─md127   9:127  0   1.5T  0 raid0 /home/data1
vdc     253:32   0 744.5G  0 disk  
└─md127   9:127  0   1.5T  0 raid0 /home/data1

image

image

Related changes

  • PR to update telemetry/data_cluster_hardware.go/telemetry/data_cluster_hardware_test.go:

Release note

  • Fix INFORMATION_SCHEMA.CLUSTER_HARDWARE dose not have raid0 devices information

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Aug 26, 2020
Merged
@ti-srebot ti-srebot added contribution This PR is from a community contributor. type/4.0-cherry-pick labels Aug 26, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Aug 26, 2020
@ti-srebot ti-srebot self-assigned this Aug 26, 2020
wjhuang2016
wjhuang2016 reviewed Aug 26, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2020
zz-jason
zz-jason approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 26, 2020
@zz-jason
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor Author

Sorry @zz-jason, you don't have permission to trigger auto merge event on this branch.
The version releasement is in progress.

@zz-jason
Copy link
Member

zz-jason commented Sep 2, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 2, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@zz-jason zz-jason changed the title telemetry: support collecting RAID information to CLUSTER_HARDWARE (#19171) telemetry: support collecting RAID information to ... (#19171) Sep 2, 2020
@zz-jason zz-jason merged commit 9be2237 into pingcap:release-4.0 Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees

@ti-srebot ti-srebot

Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @zz-jason @wjhuang2016 @motecshine