Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix check partition expr miss the parentheses expr #19466

Merged
merged 9 commits into from
Aug 31, 2020
Merged

ddl: fix check partition expr miss the parentheses expr #19466

merged 9 commits into from
Aug 31, 2020

Conversation

lzmhhh123
Copy link
Contributor

@lzmhhh123 lzmhhh123 commented Aug 26, 2020 •
edited
Loading

What problem does this PR solve?

Issue Number: close #17806 and close #17804

What is changed and how it works?

How it Works: in checkPartitionExprValid, it should consider ParenthesesExpr.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU

Release note

  • fix check partition expression miss the parentheses expression

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Aug 26, 2020
wjhuang2016
wjhuang2016 reviewed Aug 31, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2020
imtbkcat
imtbkcat approved these changes Aug 31, 2020
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@imtbkcat,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: ddl(slack).

@lzmhhh123 lzmhhh123 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 31, 2020
@lzmhhh123
Copy link
Contributor Author

/run-all-tests

@lzmhhh123
Copy link
Contributor Author

/run-all-tests

@lzmhhh123 lzmhhh123 merged commit 15f300b into pingcap:master Aug 31, 2020
@lzmhhh123 lzmhhh123 deleted the bug-fix/fix_wrong_error_message_create_partition branch August 31, 2020 07:07
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 31, 2020
@lzmhhh123 @ti-srebot
cherry pick pingcap#19466 to release-3.0
644a35a 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 31, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #19613

@ti-srebot ti-srebot mentioned this pull request Aug 31, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #19614

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 31, 2020
@lzmhhh123 @ti-srebot
cherry pick pingcap#19466 to release-4.0
2946ba2 
Signed-off-by: ti-srebot <[email protected]>
ti-srebot added a commit that referenced this pull request Sep 1, 2020
@ti-srebot
ddl: fix check partition expr miss the parentheses expr (#19466) (#19614
d76bab9 
)

Signed-off-by: ti-srebot <[email protected]>
bb7133 pushed a commit that referenced this pull request Sep 1, 2020
@ti-srebot
ddl: fix check partition expr miss the parentheses expr (#19466) (#19613
481e668 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@imtbkcat imtbkcat imtbkcat approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@bb7133 bb7133 Awaiting requested review from bb7133

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
4 participants
@lzmhhh123 @ti-srebot @imtbkcat @wjhuang2016