Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add concurrency limit on union executor (#19827) #19885

Merged
merged 6 commits into from
Sep 17, 2020
Merged

executor: add concurrency limit on union executor (#19827) #19885

merged 6 commits into from
Sep 17, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19827 to release-3.0

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

  1. Use system variable tidb_executor_concurrency to control the concurrency on union executor.
  2. Create n worker to pull result from executors.
  3. Close children executors that has been opened.

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch 4.0

Check List

Tests

  • Unit test

Side effects

  • Performance regression

Release note

  • Support adjust the concurrency on union executor.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Sep 8, 2020
Merged
@ti-srebot ti-srebot added priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution type/3.0-cherry-pick labels Sep 8, 2020
@ti-srebot ti-srebot added this to the 3.0.19 milestone Sep 8, 2020
@tiancaiamao
Copy link
Contributor

Please address conflict @wshwsh12

@wshwsh12
Copy link
Contributor

/run-all-tests

@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2020
@XuHuaiyu
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 17, 2020
@XuHuaiyu
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 17, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@coocood
Copy link
Member

coocood commented Sep 17, 2020

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 19759

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@wjhuang2016
Copy link
Member

/run-unit-test

@wjhuang2016
Copy link
Member

/run-all-tests

@wjhuang2016
Copy link
Member

/run-unit-test

@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@zhouqiang-cl zhouqiang-cl merged commit 179c131 into pingcap:release-3.0 Sep 17, 2020
@wjhuang2016 wjhuang2016 mentioned this pull request Sep 24, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@lysu lysu Awaiting requested review from lysu

Assignees

@wshwsh12 wshwsh12

Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick
Projects
None yet
Milestone
v3.0.19
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @tiancaiamao @wshwsh12 @XuHuaiyu @coocood @wjhuang2016 @zhouqiang-cl