Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distsql: add metrics for coprocessor cache #19979

Merged
merged 8 commits into from
Sep 29, 2020
Merged

distsql: add metrics for coprocessor cache #19979

merged 8 commits into from
Sep 29, 2020

Conversation

lzmhhh123
Copy link
Contributor

@lzmhhh123 lzmhhh123 commented Sep 14, 2020 •
edited by ti-srebot
Loading

What problem does this PR solve?

Issue Number: close #17369

What is changed and how it works?

What's Changed:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • add metrics for coprocessor cache

@lzmhhh123 lzmhhh123 requested a review from a team as a code owner September 14, 2020 08:51
@lzmhhh123 lzmhhh123 requested review from fzhedu and removed request for a team September 14, 2020 08:51
@github-actions github-actions bot added the sig/execution SIG execution label Sep 14, 2020
SunRunAway
SunRunAway reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you modify the JSONs in metrics/grafana?

And you can /run-monitor-test to test it.

@lzmhhh123
Copy link
Contributor Author

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Sep 17, 2020

Visit the grafana server at: http://172.16.5.5:31883, it will last for 5 hours

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Sep 17, 2020
@lzmhhh123
Copy link
Contributor Author

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Sep 17, 2020

Visit the grafana server at: http://172.16.5.5:31798, it will last for 5 hours

@lzmhhh123 lzmhhh123 mentioned this pull request Sep 24, 2020
Closed
SunRunAway
SunRunAway reviewed Sep 25, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 25, 2020
XuHuaiyu
XuHuaiyu reviewed Sep 29, 2020
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 29, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 29, 2020
@lzmhhh123
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 29, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit f2d4e47 into pingcap:master Sep 29, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 29, 2020
@lzmhhh123 @ti-srebot
cherry pick pingcap#19979 to release-4.0
4d8687e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Sep 29, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20293

ti-srebot added a commit that referenced this pull request Oct 3, 2020
@ti-srebot
distsql: add metrics for coprocessor cache (#19979) (#20293)
2e0965d 
Signed-off-by: ti-srebot <[email protected]>
@lzmhhh123 lzmhhh123 deleted the dev/add_metrics_for_copr_cache branch March 26, 2021 06:59
@bb7133 bb7133 mentioned this pull request Feb 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@SunRunAway SunRunAway SunRunAway left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@fzhedu fzhedu Awaiting requested review from fzhedu

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
challenge-program sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add metrics for Copr Cache
5 participants
@lzmhhh123 @sre-bot @ti-srebot @SunRunAway @XuHuaiyu