ddl: add the not expression check when creating a partition table

ddl/db_partition_test.go

@@ -3156,3 +3156,16 @@ func (s *testIntegrationSuite7) TestAddPartitionForTableWithWrongType(c *C) {
 	c.Assert(err, NotNil)
 	c.Assert(ddl.ErrWrongTypeColumnValue.Equal(err), IsTrue)
 }
+
+func (s *testIntegrationSuite5) TestBuildPartitionWithExpr(c *C) {
+	tk := testkit.NewTestKit(c, s.store)
+	tk.MustExec("set @@session.tidb_enable_table_partition = 1;")
+	tk.MustExec("use test;")
+	tk.MustExec("drop table if exists t;")
+
+	sql1 := `CREATE TABLE t1(c0 INT) PARTITION BY HASH((NOT c0)) PARTITIONS 2;`
+	tk.MustGetErrCode(sql1, tmysql.ErrPartitionFunctionIsNotAllowed)
+
+	sql2 := `CREATE TABLE t1(c0 INT) PARTITION BY HASH(!c0) PARTITIONS 2;`
+	tk.MustGetErrCode(sql2, tmysql.ErrPartitionFunctionIsNotAllowed)
+}

ddl/partition.go

@@ -1672,21 +1672,27 @@ func checkPartitionExprAllowed(_ sessionctx.Context, _ *model.TableInfo, e ast.E
 }
 
 func checkPartitionExprFuncAllowed(_ sessionctx.Context, _ *model.TableInfo, e ast.ExprNode) error {
-	expr, ok := e.(*ast.FuncCallExpr)
-	if !ok {
-		return nil
-	}
-	allowedFuncMap := map[string]struct{}{
-		ast.ToDays: {}, ast.ToSeconds: {}, ast.DayOfMonth: {}, ast.Month: {}, ast.DayOfYear: {},
-		ast.Quarter: {}, ast.YearWeek: {}, ast.Year: {}, ast.Weekday: {}, ast.DayOfWeek: {}, ast.Day: {},
-		ast.Hour: {}, ast.Minute: {}, ast.Second: {}, ast.TimeToSec: {}, ast.MicroSecond: {},
-		ast.UnixTimestamp: {}, ast.FromDays: {}, ast.Extract: {}, ast.Abs: {}, ast.Ceiling: {},
-		ast.DateDiff: {}, ast.Floor: {}, ast.Mod: {},
-	}
-	if _, ok := allowedFuncMap[expr.FnName.L]; ok {
-		return nil
+	var err error
+	switch expr := e.(type) {
+	case *ast.FuncCallExpr:
+		allowedFuncMap := map[string]struct{}{
+			ast.ToDays: {}, ast.ToSeconds: {}, ast.DayOfMonth: {}, ast.Month: {}, ast.DayOfYear: {},
+			ast.Quarter: {}, ast.YearWeek: {}, ast.Year: {}, ast.Weekday: {}, ast.DayOfWeek: {}, ast.Day: {},
+			ast.Hour: {}, ast.Minute: {}, ast.Second: {}, ast.TimeToSec: {}, ast.MicroSecond: {},
+			ast.UnixTimestamp: {}, ast.FromDays: {}, ast.Extract: {}, ast.Abs: {}, ast.Ceiling: {},
+			ast.DateDiff: {}, ast.Floor: {}, ast.Mod: {},
+		}
+		if _, ok := allowedFuncMap[expr.FnName.L]; !ok {
+			err = errors.Trace(ErrPartitionFunctionIsNotAllowed)
+		}
+	case *ast.UnaryOperationExpr:
+		switch expr.Op {
+		// We can not build partition with `not` expression. But in TiDB, `not` will be regard as a operator.
+		case opcode.Not, opcode.Not2:
+			err = errors.Trace(ErrPartitionFunctionIsNotAllowed)
+		}
 	}
-	return errors.Trace(ErrPartitionFunctionIsNotAllowed)
+	return err
 }
 
 func checkPartitionExprArgs(_ sessionctx.Context, tblInfo *model.TableInfo, e ast.ExprNode) error {