Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oracle: support txnScope for GetStaleTimestamp #21967

Merged
merged 5 commits into from
Dec 24, 2020
Merged

oracle: support txnScope for GetStaleTimestamp #21967

merged 5 commits into from
Dec 24, 2020

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Dec 23, 2020 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #21717

Problem Summary:

GetStaleTimestamp only support global currentlly, this request make it support txnScope.

Release note

  • No release note

@Yisaer
Copy link
Contributor Author

Yisaer commented Dec 24, 2020

@nolouch @djshow832 PTAL

djshow832
djshow832 reviewed Dec 24, 2020
View reviewed changes
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2020
nolouch
nolouch approved these changes Dec 24, 2020
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 24, 2020
@nolouch
Copy link
Member

nolouch commented Dec 24, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 24, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 1db1880 into pingcap:master Dec 24, 2020
Tjianke pushed a commit to Tjianke/tidb that referenced this pull request Dec 25, 2020
@Yisaer
oracle: support txnScope for GetStaleTimestamp (pingcap#21967)
7573fd2
@Yisaer Yisaer mentioned this pull request Dec 25, 2020
Closed
@Yisaer
Copy link
Contributor Author

Yisaer commented Jan 13, 2021

/label sig/infra

@ti-srebot ti-srebot added the sig/sql-infra SIG: SQL Infra label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yisaer @nolouch @ti-srebot @djshow832