Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: fix didn't change current version in #21856 #22011

Merged
merged 3 commits into from
Dec 25, 2020

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Dec 24, 2020

What problem does this PR solve?

Problem Summary: didn't sync currentBootstrapVersion with largest version in #21856

What is changed and how it works?

What's Changed: update it. may need a test to ensure it

How it Works:

Related changes

Check List

Tests

  • pass original tests

Side effects

Release note

  • No release note

@lance6716
Copy link
Contributor Author

PTAL @wjhuang2016 @SunRunAway

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 24, 2020
@lance6716
Copy link
Contributor Author

PTAL @AilinKid @XuHuaiyu

Copy link
Contributor

@3pointer 3pointer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 25, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 25, 2020
@lance6716
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 25, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 4fdc99b into pingcap:master Dec 25, 2020
@lance6716 lance6716 deleted the fix-bootstrap-verion branch December 25, 2020 03:21
@lance6716
Copy link
Contributor Author

/label needs-cherry-pick-5.0-rc

@ti-srebot
Copy link
Contributor

cherry pick to release-5.0-rc in PR #22113

@lance6716
Copy link
Contributor Author

/unlabel needs-cherry-pick-5.0-rc

will manually cherry-pick in #22112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants