config, session: promise the compatibility of oom-action when upgrading (#22102) #22111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
@XuHuaiyu you're already a collaborator in bot's repo. |
wshwsh12
force-pushed
the
release-5.0-rc-c40d7833b8e9
branch
from
d315e8f
to
acb3f99
Compare
lzmhhh123
approved these changes
Dec 30, 2020
ti-srebot
added
status/LGT2
|
/merge |
|
Sorry @lzmhhh123, this branch's release version is in progress, please contact zhouqiang-cl,shuke987,jebter for more details. |
XuHuaiyu
approved these changes
Dec 30, 2020
ti-srebot
added
status/LGT3
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #22102 to release-5.0-rc
What problem does this PR solve?
Issue Number: close #17979
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Write the default value(log) into mysql.tidb if the cluster is upgraded from 3.0.x to 4.0.11+.
When start tidb-server, check:
whether oom-action is configured by the user. If so, use the value. If not, goto 2
whether the var default_oom_action exists in mysql.tidb. If so, use the value. If not, goto 3.
Use the default value(cancel) in 4.0.11+.
How it Works:
Related changes
Check List
Tests
Side effects
Release note
oom-actionwhen upgrading.