executor: fix SelectForUpdate in decorrelated subquery under pessimistic mode

[lysu]

Signed-off-by: lysu [email protected]

What problem does this PR solve?

Issue Number: close #22345

Problem Summary:

just as issue described, we need handle pessimistic error when SFU in decorrelated subquery

What is changed and how it works?

What's Changed, How it Works::

• refactor (a *ExecStmt) handlePessimisticLockError to handlePessimisticLockError without change logic
• call it in EvalSubqueryFirstRow

Related changes

• Need to cherry-pick to the release branch

Check List

Tests

• Unit test

Side effects

• n/a

Release note

• Fix SelectForUpdate in decorrelated subquery return unexpected WriteConflictError under pessimistic mode

---

This change is 

[cfzjywxk]

LGTM

[you06]

Does it execute the whole query inside EvalSubqueryFirstRow?

[lysu]

IMO, it only execute subplan subquery for example:

select v from t where id = 1 for update of select (select v from t where id = 1 for update) v1, (select v from t where id = 2) from dual

[you06]

LGTM

[ti-srebot]

@you06, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIGs: execution(slack),sql-infra(slack).

[ti-srebot]

@youjiali1995, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIGs: execution(slack),sql-infra(slack).

[ti-chi-bot]

@lysu: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.