*: refactor ExecuteInternal to return single resultset #22546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sig/execution
|
Interesting. It looks like this breaks the API used by plugins. It might require some more thought on how/when to break it. |
tiancaiamao
reviewed
Jan 27, 2021
|
/run-build enterprise-plugin=pr/39 |
|
/run-all-tests enterprise-plugin=pr/39 |
morgo
force-pushed
the
fix-execute-to-single-return
branch
from
e943f72
to
f9eea80
Compare
morgo
changed the title
|
/run-all-tests |
|
/run-all-tests |
|
/run-tics-test |
morgo
changed the title
|
I've simplified this to only clean up PTAL @tiancaiamao @xhebox |
|
LGTM |
ti-srebot
approved these changes
Feb 1, 2021
AilinKid
approved these changes
Feb 1, 2021
ti-srebot
added
status/LGT3
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@morgo merge failed. |
|
/run-tics-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Feb 1, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #22640 |
|
cherry pick to release-5.0-rc in PR #22655 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Feb 2, 2021
Signed-off-by: ti-srebot <[email protected]>
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Feb 3, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-3.0 in PR #22712 |
ti-srebot
added a commit
that referenced
this pull request
Feb 4, 2021
Signed-off-by: ti-srebot <[email protected]>
ti-chi-bot
pushed a commit
that referenced
this pull request
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Both
ExecuteandExecuteInternalno longer permit multi-statement, but the return type was maintained the same for backward compatibility.This changes
ExecuteInternalto return a single result-set.Update: I've removed
Executefrom this PR, we can handle it in followup PRs.What is changed and how it works?
What's Changed:
This changes the return type of
ExecuteInternalto be a non-array value.All uses of(for future PRs - it does not need to be handled all at once).Executeare changed to useExecuteInternalRelated changes
Check List
Tests
Side effects
Release note