*: do not report error for prepared stmt execution if tidb_snapshot is set (#22568) #22641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
ti-srebot
added
component/executor
sig/execution
|
@eurekaka you're already a collaborator in bot's repo. |
Signed-off-by: ti-srebot <[email protected]>
eurekaka
force-pushed
the
release-4.0-843e03996b10
branch
from
c82a8de
to
91da71d
Compare
ti-srebot
added
status/LGT2
ti-chi-bot
added
the
size/M
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #22568 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/22641After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #22497
Fix #22567
Problem Summary:
The first issue is for code cleanup, while the second issue is a bug.
What is changed and how it works?
What's Changed:
snapshotfrompstmtPlanCacheKey;txn()if snapshot is set manually;Related changes
4.0 has this problem as well,
167edacdbfb1db59b6d10c4f6a0ed2b08d0abca8.Check List
Tests
Side effects
N/A
Release note