Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: support checking schemaVer before staleness transaction begins #22679

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Feb 2, 2021

What problem does this PR solve?

Issue Number: ref #22427

Problem Summary:

There will be compatible problem between ddl changing and staelness transaction.

What is changed and how it works?

This request compare the schemaVer by the stale startTS with current schemaVer in order to avoid this problem as a temporary solution.

Check List

Tests

  • Unit test

Release note

  • No release note

@Yisaer Yisaer requested a review from a team as a code owner February 2, 2021 11:59
@Yisaer Yisaer requested review from XuHuaiyu and removed request for a team February 2, 2021 11:59
@Yisaer
Copy link
Contributor Author

Yisaer commented Feb 2, 2021

/cc @djshow832 @xhebox

@github-actions github-actions bot added the sig/execution SIG execution label Feb 2, 2021
@Yisaer
Copy link
Contributor Author

Yisaer commented Feb 3, 2021

/label sig/infra

@ti-srebot ti-srebot added the sig/sql-infra SIG: SQL Infra label Feb 3, 2021
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

executor/simple.go Show resolved Hide resolved
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 3, 2021
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Feb 4, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 4, 2021
@djshow832
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 4, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 93d3d04 into pingcap:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants