Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: scattering truncated tables without pre-split option #22787

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Feb 18, 2021

Signed-off-by: Shuaipeng Yu [email protected]

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
The current truncate table statement could not scatter regions for tables without pre-split option.

What is changed and how it works?

Proposal: xxx

What's Changed:
Make scattering regions for truncated tables without pre-split option.

How it Works:

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • start a cluster
    • truncate some tables which have no pre-split option
    • grep the log files of pd server for 'add operator', it will have 'transfer leader' and 'mv light peer' (will not see mv operator because misuse ScatterRegions api in pdclient, see Scatter region when creating tables is not work #22788).

Release note

  • Scattering truncated tables without pre-split option.

Signed-off-by: Shuaipeng Yu <[email protected]>
@bb7133
Copy link
Member

bb7133 commented Feb 20, 2021

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 20, 2021
@jackysp jackysp added the type/bugfix This PR fixes a bug. label Feb 22, 2021
@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 22, 2021
@tiancaiamao
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 49f3e29 into pingcap:master Feb 22, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Feb 22, 2021
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #22872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants