Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: support to store FMSketch and add FMSketch to column stats #22841

Merged
merged 24 commits into from
Feb 23, 2021
Merged

statistics: support to store FMSketch and add FMSketch to column stats #22841

merged 24 commits into from
Feb 23, 2021

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Feb 20, 2021 •
edited
Loading

What problem does this PR solve?

related issue#18551

Problem Summary:
Add FMSketch to the column stats and store the FMSketch in the mysql.stats_fm_sketch table.

What is changed and how it works?

Same as described above.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

@Reminiscent Reminiscent requested a review from a team as a code owner February 20, 2021 04:31
@Reminiscent Reminiscent requested review from hanfei1991 and removed request for a team February 20, 2021 04:31
@qw4990 qw4990 requested review from qw4990 and removed request for hanfei1991 February 22, 2021 02:55
qw4990
qw4990 reviewed Feb 22, 2021
View reviewed changes
session/bootstrap.go Outdated Show resolved Hide resolved
qw4990
qw4990 reviewed Feb 22, 2021
View reviewed changes
statistics/histogram.go Outdated Show resolved Hide resolved
@Reminiscent Reminiscent requested a review from a team as a code owner February 22, 2021 03:33
@Reminiscent Reminiscent changed the title statistics: support store FMSketch and add FMSketch to histogram statistics: support to store FMSketch and add FMSketch to column stats Feb 22, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Feb 22, 2021
Reminiscent
Reminiscent commented Feb 22, 2021
View reviewed changes
statistics/fmsketch.go Outdated Show resolved Hide resolved
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 22, 2021
@Reminiscent
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2021
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@Reminiscent merge failed.

@Reminiscent
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2021
@ti-chi-bot
Copy link
Member

@Reminiscent: Your PR has out-of-dated, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 22, 2021
@CLAassistant
Copy link

CLAassistant commented Feb 22, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Reminiscent
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@Reminiscent: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@Reminiscent: /merge in this pull request requires 3 /lgtm.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Reminiscent
Copy link
Contributor Author

/remove-sig sql-infa

@ti-chi-bot
Copy link
Member

@Reminiscent: Those labels are not set on the issue: sig/sql-infa

In response to this:

/remove-sig sql-infa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Reminiscent
Copy link
Contributor Author

/remove-sig sql-infra

@ti-chi-bot ti-chi-bot removed the sig/sql-infra SIG: SQL Infra label Feb 23, 2021
@Reminiscent
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@Reminiscent: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f922857

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2021
@Reminiscent
Copy link
Contributor Author

/run-tics-test

@Reminiscent
Copy link
Contributor Author

/run-unit-test

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Feb 23, 2021
@ti-chi-bot ti-chi-bot merged commit f3fe489 into pingcap:master Feb 23, 2021
@Reminiscent Reminiscent deleted the mergeNDV branch August 5, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@rebelice rebelice rebelice left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
component/statistics sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Reminiscent @rebelice @ti-srebot @ti-chi-bot @CLAassistant @qw4990