Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: quote identifier with backquote when getting SQL digest #22893

Merged
merged 10 commits into from
Feb 26, 2021
Merged

parser: quote identifier with backquote when getting SQL digest #22893

merged 10 commits into from
Feb 26, 2021

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Feb 23, 2021 •
edited by morgo
Loading

What problem does this PR solve?

Fixes #14241

update parser and fix tests

Related changes

Check List

Tests

  • Unit test

Release note

  • quote identifier with backquote when getting SQL digest

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 23, 2021
@github-actions github-actions bot added sig/execution SIG execution sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra labels Feb 23, 2021
@xiongjiwei
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 24, 2021
@xiongjiwei xiongjiwei changed the title digest: quote identifier with back quote when get sql digest digest: quote identifier with backquote when getting SQL digest Feb 24, 2021
@xiongjiwei xiongjiwei changed the title digest: quote identifier with backquote when getting SQL digest parser: quote identifier with backquote when getting SQL digest Feb 24, 2021
@xiongjiwei xiongjiwei marked this pull request as ready for review February 24, 2021 03:10
@xiongjiwei xiongjiwei requested review from a team as code owners February 24, 2021 03:10
@xiongjiwei xiongjiwei requested review from wshwsh12 and hanfei1991 and removed request for a team February 24, 2021 03:10
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2021
@xiongjiwei
Copy link
Contributor Author

/cc @morgo

@morgo
Copy link
Contributor

morgo commented Feb 24, 2021

Please include a bind test or an integration test with a table + column that consists of a reserved word.

xiongjiwei
xiongjiwei commented Feb 24, 2021
View reviewed changes
infoschema/tables_test.go Outdated Show resolved Hide resolved
@xiongjiwei
Copy link
Contributor Author

/run-all-tests

@xiongjiwei
Copy link
Contributor Author

/run-tics-test

@xiongjiwei
Copy link
Contributor Author

/run-unit-test

@xiongjiwei
Copy link
Contributor Author

/cc @rebelice

tangenta
tangenta reviewed Feb 24, 2021
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

xhebox
xhebox reviewed Feb 26, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

infoschema/tables_test.go Show resolved Hide resolved
infoschema/tables_test.go Show resolved Hide resolved
@xhebox
Copy link
Contributor

xhebox commented Feb 26, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 26, 2021
@tangenta
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 26, 2021
@xiongjiwei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@xiongjiwei: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b0a9f5f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 26, 2021
@xiongjiwei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@xiongjiwei: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@xiongjiwei
Copy link
Contributor Author

/run-e2e-test

@ti-chi-bot ti-chi-bot merged commit 8a490e9 into pingcap:master Feb 26, 2021
@xiongjiwei xiongjiwei added the type/bugfix This PR fixes a bug. label Oct 13, 2021
@xiongjiwei xiongjiwei deleted the fix-digest branch September 23, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox left review comments

@tangenta tangenta tangenta left review comments

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

@morgo morgo Awaiting requested review from morgo

@rebelice rebelice Awaiting requested review from rebelice

Assignees
No one assigned
Labels
sig/execution SIG execution sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Digester does not support escaped reserved words
5 participants
@xiongjiwei @morgo @xhebox @tangenta @ti-chi-bot