Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv: drop store's regions when resolve store with tombstone status (#22909) #23071

Merged
merged 3 commits into from
Mar 15, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 3, 2021

cherry-pick #22909 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23071

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/23071:release-4.0-abbf3fe8e638

Signed-off-by: lysu [email protected]

What problem does this PR solve?

Issue Number: close #22907

Problem Summary:

old store id can get old tombstone store, so never have chance to refresh region peer to point to new store id

so request will block forever in old store with EpochNotMatchError

What is changed and how it works?

What's Changed:

drop region cache when resolve store but it's tombstone status

How it Works:

after it, retry will re-fetch new region info from PD which point to new store id..

so continue request will got to new store and never block

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch 4.0/3.0

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • n/a

Release note

  • Fix request block forever when replace a tombstone store with the store has same IP addr

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 3, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot
Copy link
Contributor Author

@lysu you're already a collaborator in bot's repo.

@tiancaiamao
Copy link
Contributor

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 5, 2021
@tiancaiamao
Copy link
Contributor

PTAL @coocood

@coocood
Copy link
Member

coocood commented Mar 15, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • coocood
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2021
@coocood
Copy link
Member

coocood commented Mar 15, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4533f5c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit b848a5d into pingcap:release-4.0 Mar 15, 2021
@zhouqiang-cl zhouqiang-cl removed this from the v4.0.11 milestone Mar 26, 2021
@zhouqiang-cl zhouqiang-cl added this to the v4.0.12 milestone Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/transaction SIG:Transaction size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants