Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix range partition prune bug for IN expr (#22894) (#22938) #23074

Merged
merged 5 commits into from
Mar 18, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 3, 2021

cherry-pick #22938 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/23074

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/23074:release-4.0-3f7a573caacb

Signed-off-by: guo-shaoge [email protected]

What problem does this PR solve?

Issue Number: close #22894

Problem Summary: The implementation of partition prune for IN expression got bug. We should use part_fn(const_arg_of_IN_expr) to calc partition id, but the current implement just use const_arg_of_IN_expr to calc partition id.

What is changed and how it works?

What's Changed: change planner.core.partitionRangeForInExpr()

How it Works: Change partitionRangeForInExpr(). For each const arg of IN expr, if part_fn is not nil, use part_fn(const_arg_of_IN_expr) to calc partition id. Otherwise, use const_arg_of_IN_expr to calc partition id.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

  • Manual test (add detailed scripts or steps below)

    use test;
    drop table if exists IDT_RP2205;
    CREATE TABLE `IDT_RP2205` (   `COL1` tinyint(11) DEFAULT '24' COMMENT 'NUMERIC UNIQUE INDEX') 
    PARTITION BY RANGE ( `COL1`%2 ) (
        PARTITION `P0` VALUES LESS THAN (0),
        PARTITION `P1` VALUES LESS THAN (10),
        PARTITION `P2` VALUES LESS THAN (20),
        PARTITION `P3` VALUES LESS THAN (30),
        PARTITION `P4` VALUES LESS THAN (40),
        PARTITION `P5` VALUES LESS THAN (50),
        PARTITION `PMX` VALUES LESS THAN (MAXVALUE) );
    insert into IDT_RP2205 values(127);
    select * from IDT_RP2205 where col1 in (127);
    select * from IDT_RP2205 where col1 in (127,127);
    

Side effects: No side effects

Release note

  • fix range partition prune bug for IN expr

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 3, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@guo-shaoge you're already a collaborator in bot's repo.

@guo-shaoge
Copy link
Collaborator

/retest

@guo-shaoge
Copy link
Collaborator

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

/run-check-release-note

@tiancaiamao
Copy link
Contributor

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2021
@tiancaiamao
Copy link
Contributor

PTAL @crazycs520

1 similar comment
@tiancaiamao
Copy link
Contributor

PTAL @crazycs520

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@crazycs520: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@crazycs520
Copy link
Contributor

/lgtm
/approve

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2021
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f966699

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 18, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 6969242 into pingcap:release-4.0 Mar 18, 2021
@tiancaiamao tiancaiamao deleted the release-4.0-3f7a573caacb branch March 18, 2021 12:00
@zhouqiang-cl zhouqiang-cl modified the milestones: v4.0.11, v4.0.12 Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. severity/major sig/execution SIG execution sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants