-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix range partition prune bug for IN expr (#22894) (#22938) #23074
planner: fix range partition prune bug for IN expr (#22894) (#22938) #23074
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
@guo-shaoge you're already a collaborator in bot's repo. |
/retest |
/run-all-tests |
/run-check-release-note |
/LGTM |
PTAL @crazycs520 |
1 similar comment
PTAL @crazycs520 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crazycs520: Please use If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f966699
|
/merge |
/merge |
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #22938 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/23074
After apply modifications, you can push your change to this PR via:
Signed-off-by: guo-shaoge [email protected]
What problem does this PR solve?
Issue Number: close #22894
Problem Summary: The implementation of partition prune for IN expression got bug. We should use part_fn(const_arg_of_IN_expr) to calc partition id, but the current implement just use const_arg_of_IN_expr to calc partition id.
What is changed and how it works?
What's Changed: change planner.core.partitionRangeForInExpr()
How it Works: Change partitionRangeForInExpr(). For each const arg of IN expr, if part_fn is not nil, use part_fn(const_arg_of_IN_expr) to calc partition id. Otherwise, use const_arg_of_IN_expr to calc partition id.
Related changes
Check List
Tests
Integration test
Manual test (add detailed scripts or steps below)
Side effects: No side effects
Release note