Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix wrong table filters for index merge plan #23132

Merged
merged 3 commits into from
Mar 8, 2021
Merged

planner: fix wrong table filters for index merge plan #23132

merged 3 commits into from
Mar 8, 2021

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Mar 5, 2021

What problem does this PR solve?

Issue Number: close #23112

Problem Summary:

Wrong result for index merge plan.

What is changed and how it works?

What's Changed:

Keep the whole DNF filter if any partial path contains table filters.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Fix wrong table filters for index merge plan

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner needs-cherry-pick-4.0 labels Mar 5, 2021
@eurekaka eurekaka requested a review from a team as a code owner March 5, 2021 07:16
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 5, 2021
time-and-fate
time-and-fate approved these changes Mar 5, 2021
View reviewed changes
Copy link
Member

@time-and-fate time-and-fate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 5, 2021
@eurekaka eurekaka force-pushed the index_merge branch 2 times, most recently from 1ee701e to fb2ad6c Compare March 5, 2021 09:48
@ichn-hu ichn-hu mentioned this pull request Mar 5, 2021
Closed
@time-and-fate
Copy link
Member

I think 8b32683 is the correct commit. The current commit doesn't contain changes in integration_suite_out.json.

@qw4990
Copy link
Contributor

qw4990 commented Mar 8, 2021

/LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 8, 2021
@eurekaka
Copy link
Contributor Author

eurekaka commented Mar 8, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1004733

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 8, 2021
@eurekaka
Copy link
Contributor Author

eurekaka commented Mar 8, 2021

/run-mybatis-test
/run-sqllogic-test

1 similar comment
@eurekaka
Copy link
Contributor Author

eurekaka commented Mar 8, 2021

/run-mybatis-test
/run-sqllogic-test

@lilinghai
Copy link
Contributor

/run-all-tests

@eurekaka
Copy link
Contributor Author

eurekaka commented Mar 8, 2021

/run-unit-test

@eurekaka
Copy link
Contributor Author

eurekaka commented Mar 8, 2021

/merge

@eurekaka eurekaka merged commit 9ac5b7a into pingcap:master Mar 8, 2021
@eurekaka eurekaka deleted the index_merge branch March 8, 2021 07:51
@ti-srebot ti-srebot mentioned this pull request Mar 8, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #23165

@ti-srebot ti-srebot mentioned this pull request Mar 8, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0-rc in PR #23166

eurekaka added a commit to ti-srebot/tidb that referenced this pull request Mar 8, 2021
@eurekaka
cherry pick pingcap#23132 to release-5.0-rc
31bee13 
Signed-off-by: ti-srebot <[email protected]>
eurekaka added a commit to ti-srebot/tidb that referenced this pull request Mar 8, 2021
@eurekaka
cherry pick pingcap#23132 to release-4.0
ac11792
eurekaka added a commit that referenced this pull request Mar 8, 2021
@ti-srebot @eurekaka
cherry pick #23132 to release-5.0-rc (#23166)
31c2570 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: Kenan Yao <[email protected]>
ti-chi-bot pushed a commit that referenced this pull request Mar 8, 2021
@ti-srebot
planner: fix wrong table filters for index merge plan (#23132) (#23165)
5c1f328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use_index_merge return wrong result
6 participants
@eurekaka @time-and-fate @qw4990 @ti-chi-bot @lilinghai @ti-srebot