Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

excutor: fix the date precision of builtinCastDurationAsStringSig.vecEvalString #23314 #23286 #23332

Merged
merged 6 commits into from
Mar 18, 2021
Merged

excutor: fix the date precision of builtinCastDurationAsStringSig.vecEvalString #23314 #23286 #23332

merged 6 commits into from
Mar 18, 2021

Conversation

Howie59
Copy link
Contributor

@Howie59 Howie59 commented Mar 16, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #23314 #23286

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • fix date precision

@Howie59 Howie59 requested a review from a team as a code owner March 16, 2021 05:25
@Howie59 Howie59 requested review from XuHuaiyu and removed request for a team March 16, 2021 05:25
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 16, 2021
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@Howie59
Copy link
Contributor Author

Howie59 commented Mar 16, 2021

/rebuild

@mmyj
Copy link
Member

mmyj commented Mar 16, 2021

LGTM

@ti-chi-bot
Copy link
Member

@mmyj: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@mmyj
Copy link
Member

mmyj commented Mar 16, 2021

/LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2021
@mmyj
Copy link
Member

mmyj commented Mar 16, 2021

#23286 had been fixed also.

@Howie59 Howie59 changed the title excutor: fix date precision #23314 excutor: fix the date precision of builtinCastDurationAsStringSig.vecEvalString #23314 #23286 Mar 16, 2021
@ichn-hu ichn-hu mentioned this pull request Mar 16, 2021
Closed
@Howie59
Copy link
Contributor Author

Howie59 commented Mar 16, 2021

@XuHuaiyu PTAL

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lzmhhh123
  • mmyj

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2021
@lzmhhh123 lzmhhh123 linked an issue Mar 18, 2021 that may be closed by this pull request
concat time data type lost the time fsp #23286
Closed
@lzmhhh123
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9c641f7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2021
@ti-chi-bot ti-chi-bot merged commit 6e00871 into pingcap:master Mar 18, 2021
@Howie59 Howie59 deleted the issue-23314 branch March 18, 2021 10:04
SabaPing pushed a commit to SabaPing/tidb that referenced this pull request Mar 25, 2021
@Howie59 @SabaPing
excutor: fix the date precision of `builtinCastDurationAsStringSig.ve…
1ef4b91 
…cEvalString` pingcap#23314 pingcap#23286 (pingcap#23332)
@wzru
Copy link
Contributor

wzru commented Aug 6, 2021

/label needs-cherry-pick-4.0

@wzru
Copy link
Contributor

wzru commented Aug 6, 2021

/label needs-cherry-pick-5.0

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 6, 2021
@Howie59 @ti-srebot
cherry pick pingcap#23332 to release-4.0
e1dac35 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 6, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #26970

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 6, 2021
@Howie59 @ti-srebot
cherry pick pingcap#23332 to release-5.0
46dff7c 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 6, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #26971

This was referenced Aug 9, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The result of GROUP_CONCAT(time) is incorrect concat time data type lost the time fsp
6 participants
@Howie59 @ti-srebot @mmyj @ti-chi-bot @lzmhhh123 @wzru