ranger: fix the range construction behavior when the column's type is YEAR

[wjhuang2016]

Signed-off-by: wjhuang2016 [email protected]

What problem does this PR solve?

Issue Number: close #23508

Problem Summary:

The type of year should be int, not double.

What is changed and how it works?

Use ConvertToMysqlYear() to adjust the year constant, and handle some corner cases.

Related changes

• Need to cherry-pick to the release branch

Check List

Tests

• Unit test

• Manual test (add detailed scripts or steps below)

Start a tidb cluster.
CREATE TABLE PK_S_MULTI_42_2 ( COL1 year(4) NOT NULL, COL2 year(4) NOT NULL, COL3 year(4) DEFAULT NULL, PRIMARY KEY (COL1,COL2) clustered);
mysql> select * from PK_S_MULTI_42_2 where col2 between 2154 and 2154 AND col3 > 2153;
Empty set (0.00 sec)

Side effects

Release note

• fix wrong year type

[ti-srebot]

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

[wjhuang2016]

/run-check_dev_2

[dyzsr]

Can someone help me /lgtm?

[lysu]

do we need fix this in 5.0 GA? @wjhuang2016 @winoros - -

[wjhuang2016]

do we need fix this in 5.0 GA? @wjhuang2016 @winoros - -

Sure , why not?

[qw4990]

@wjhuang2016 Please resolve conflicts at your convenience. And should we add some new and separated test cases for this PR?

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• qw4990
• winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

[qw4990]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: fca84b2

[wjhuang2016]

/merge

[wjhuang2016]

/merge

[wjhuang2016]

/merge

[ti-srebot]

cherry pick to release-5.0 in PR #24018