Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix the issue that planner hints don't work in some batch/point-get plans #23666

Merged
merged 10 commits into from
Mar 30, 2021
Merged

planner: fix the issue that planner hints don't work in some batch/point-get plans #23666

merged 10 commits into from
Mar 30, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Mar 30, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #23570

Problem Summary: planner: fix the issue that planner hints don't work in some batch/point-get plans

What is changed and how it works?

Add some logic about checking planner hints in TryFastPlan.
Please see the root cause and more details in #23570.

Check List

Tests

  • Unit test

Release note

  • planner: fix the issue that planner hints don't work in some batch/point-get plans

@qw4990 qw4990 added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Mar 30, 2021
@qw4990 qw4990 requested a review from a team as a code owner March 30, 2021 07:50
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 30, 2021
@ichn-hu ichn-hu mentioned this pull request Mar 30, 2021
Closed
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 30, 2021
@rebelice
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rebelice
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 30, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 78b18f5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 30, 2021

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 30, 2021

/merge

@qw4990 qw4990 merged commit 60111e1 into pingcap:master Mar 30, 2021
@ti-srebot ti-srebot mentioned this pull request Mar 30, 2021
Merged
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 30, 2021
@qw4990 @ti-srebot
cherry pick pingcap#23666 to release-5.0
161ea67 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #23685

ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2021
@ti-srebot
planner: fix the issue that planner hints don't work in some batch/po…
1623dcc 
…int-get plans (#23666) (#23685)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelice rebelice rebelice left review comments

@winoros winoros winoros approved these changes

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

planner: hints don't work in some batch/point get cases
5 participants
@qw4990 @rebelice @ti-chi-bot @ti-srebot @winoros