Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

functions: fix some string function has wrong collation and flag #23835

Merged
merged 5 commits into from
Apr 7, 2021
Merged

functions: fix some string function has wrong collation and flag #23835

merged 5 commits into from
Apr 7, 2021

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Apr 2, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #23759

some string functions get the wrong binary flag result, the returned value has a binary flag only its return value is binary charset

Check List

Tests

  • Unit test

Release note

  • fix some string function get wrong result

@xiongjiwei xiongjiwei requested a review from a team as a code owner April 2, 2021 08:15
@xiongjiwei xiongjiwei requested review from qw4990 and removed request for a team April 2, 2021 08:15
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 2, 2021
@xiongjiwei xiongjiwei marked this pull request as draft April 2, 2021 14:54
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2021
@xiongjiwei xiongjiwei marked this pull request as ready for review April 3, 2021 05:48
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2021
@wjhuang2016
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 6, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 7, 2021
@xiongjiwei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 89e5d28

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
@xiongjiwei
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 7229416 into pingcap:master Apr 7, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 7, 2021
@xiongjiwei @ti-srebot
cherry pick pingcap#23835 to release-4.0
550bd20 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 7, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #23878

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 7, 2021
@xiongjiwei @ti-srebot
cherry pick pingcap#23835 to release-5.0
4b6439c 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 7, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #23879

ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2021
@ti-srebot
functions: fix some string function has wrong collation and flag (#23835
225f558 
) (#23879)
ti-chi-bot pushed a commit that referenced this pull request May 6, 2021
@ti-srebot
functions: fix some string function has wrong collation and flag (#23835
c21f6f2 
) (#23878)
@xiongjiwei xiongjiwei added the type/bugfix This PR fixes a bug. label Oct 13, 2021
@xiongjiwei xiongjiwei deleted the binary-flag branch September 23, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

collation and flag of some functions are wrong
5 participants
@xiongjiwei @wjhuang2016 @ti-chi-bot @ti-srebot @wshwsh12