Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store/tikv: move binlog logic to txn_driver #23873

Merged
merged 10 commits into from
Apr 12, 2021
Merged

store/tikv: move binlog logic to txn_driver #23873

merged 10 commits into from
Apr 12, 2021

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Apr 6, 2021

Signed-off-by: disksing [email protected]

What problem does this PR solve?

store/tikv depends on binlog utilities.
Part of #22513

What is changed and how it works?

What's Changed:

  • move concret binlog logic to txn driver and inject it into 2pc

Check List

Tests

  • Unit test

Release note

  • No release note

@disksing disksing added the sig/transaction SIG:Transaction label Apr 6, 2021
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 6, 2021
@disksing
Copy link
Contributor Author

disksing commented Apr 7, 2021

/run-check_dev_2

@disksing
Copy link
Contributor Author

disksing commented Apr 7, 2021

/run-all-tests

AndreMouche
AndreMouche reviewed Apr 7, 2021
View reviewed changes
store/tikv/2pc.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Apr 7, 2021
AndreMouche
AndreMouche approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 9, 2021
@disksing disksing added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2021
sticnarf
sticnarf approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AndreMouche
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 9, 2021
@AndreMouche
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1fa3de3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2021
@AndreMouche
Copy link
Contributor

/merge

@disksing disksing removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2021
@disksing disksing merged commit 5e69f9a into pingcap:master Apr 12, 2021
@disksing disksing deleted the binlog branch April 12, 2021 03:36
@lysu lysu mentioned this pull request Apr 21, 2021
Merged
@disksing disksing mentioned this pull request Apr 26, 2021
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sticnarf sticnarf sticnarf approved these changes

@AndreMouche AndreMouche AndreMouche approved these changes

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra sig/transaction SIG:Transaction size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@disksing @ti-chi-bot @AndreMouche @sticnarf