-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: check NotNullFlag of columns when simplifying binary operations #24049
Conversation
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7e57d02
|
/run-check_dev_2 |
1 similar comment
/run-check_dev_2 |
cherry pick to release-5.0 in PR #24063 |
Signed-off-by: ti-srebot <[email protected]>
What problem does this PR solve?
Issue Number: close #23891
Problem Summary:
Wrong result of queries.
What is changed and how it works?
What's Changed:
Check NotNullFlag in
refineArgs
before saying that the result of the expression is exceptional.Related changes
Check List
Tests
Side effects
N/A
Release note